skynet/agent-runtime-framework
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(agent-repo): capture git push output explicitly for diagnosis

Browse Source 
Probe 6 (2026-05-08) showed git push failing twice with exit 1 and
zero visible output — the previous form `if cmd 2>&1; then` redirected
git's stderr to stdout where the entrypoint's stderr-only log capture
missed it. CP-side log showed only the bash `set -x` trace, not the
actual git error message (e.g., "Permission denied (publickey)" or
"remote: pre-receive hook rejected").

Refactor the push retry loop:
- Capture output to PUSH_OUT via $() with `2>&1`
- Wrap in set +e/set -e to detect non-zero without aborting
- echo PUSH_OUT to stderr (where set -x trace also goes) so the
  entrypoint's stderr capture sees it

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Paul O'Reilly
2026-05-08 17:03:12 +12:00
parent 9cf016fa1c
commit bf18ca3ef5
1 changed files with 13 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
harnesses/contexts/agent-repo/v1/finalize.sh
View File

@@ -344,13 +344,23 @@ for attempt in $(seq 1 $((PUSH_RETRIES + 1))); do
sleep 5 sleep 5
echo "Retry $attempt: git push $REPO_URL HEAD:refs/heads/$BRANCH --force" echo "Retry $attempt: git push $REPO_URL HEAD:refs/heads/$BRANCH --force"
fi fi
if timeout 120 git push "$REPO_URL" "HEAD:refs/heads/$BRANCH" --force 2>&1; then # Capture push output explicitly to stderr so it shows in finalize-error
# capture (the previous `if cmd 2>&1; then` form let git stderr go to
# stdout where it was lost — the actual push error message wasn't
# visible in CP logs, hiding e.g. "Permission denied (publickey)" or
# "remote: error: ..." rejections. Real incident: 2026-05-08 probe 6
# silently failed for 6 retries with no visible reason.
set +e
PUSH_OUT=$(timeout 120 git push "$REPO_URL" "HEAD:refs/heads/$BRANCH" --force 2>&1)
PUSH_EXIT=$?
set -e
echo "git push attempt $attempt exit=$PUSH_EXIT, output:" >&2
echo "$PUSH_OUT" >&2
if [ "$PUSH_EXIT" -eq 0 ]; then
echo "Push succeeded (attempt $attempt)" echo "Push succeeded (attempt $attempt)"
PUSHED=true PUSHED=true
PUSH_EXIT=0
break break
else else
PUSH_EXIT=$?
echo "Push attempt $attempt failed with exit code $PUSH_EXIT" echo "Push attempt $attempt failed with exit code $PUSH_EXIT"
if [ "$attempt" -lt $((PUSH_RETRIES + 1)) ]; then if [ "$attempt" -lt $((PUSH_RETRIES + 1)) ]; then
echo "Will retry..." echo "Will retry..."