e89208f44b
All 6 concept/idea-stage templates hardcoded the literal shared branch
spec/auto-draft instead of a per-item branch. Concurrent concept items
(now routine via the M41 auto-advance sweep) all pushed to the same
branch — a git collision risk. Switched to spec/${item.uuid}, matching
the established task/${item.uuid} convention used by every task-stage
template (merge@1, scaffold@1, etc — see spec/typed-workflows.md WF-COMP
stable-per-item-branch rationale). spec-review-loop@1's 4 nodes keep the
literal branch shared ACROSS the node set (now per-item, not global) so
loop iterations still accumulate on one branch per item, per spec's
cross-iteration-artifact caveat.
Files: review-spec-arch-opus@1.yaml, spec-draft-opus@1.yaml,
spec-review-loop@1.yaml, review-spec-arch-airouter@1.yaml,
spec-draft-airouter@2.yaml, scope-decompose-sonnet@1.yaml
49 lines
1.6 KiB
YAML
49 lines
1.6 KiB
YAML
name: review-spec-arch-airouter
|
|
version: 1
|
|
description: Architecture review of a spec draft
|
|
runtime: best-practices-airouter-repo
|
|
input:
|
|
state: spec-draft
|
|
tags_forbidden: [security-sensitive]
|
|
required_artifacts: [spec_file]
|
|
output:
|
|
state: spec-reviewed-arch
|
|
scope_budget:
|
|
files_modified_max: 2
|
|
lines_diff_max: 150
|
|
wall_clock_seconds_max: 1800
|
|
nodes:
|
|
- id: agent
|
|
kind: agent
|
|
template: best-practices-airouter-repo
|
|
cli: agentic
|
|
model: Qwen3.6
|
|
labels: [airouter]
|
|
runtime_env:
|
|
AGENT_REPO_URL: "git@gitea.oreillyit.nz-ai-enablement:skynet/agent-runtimes-agents.git"
|
|
AGENT_BRANCH: "spec/${item.uuid}"
|
|
prompt: |
|
|
The agent-runtimes project repo is cloned at /workspace/project.
|
|
Change to that directory before doing any work.
|
|
|
|
Review the spec draft for the following concept.
|
|
|
|
**Title**: ${item.title}
|
|
|
|
**Original concept**:
|
|
${item.body}
|
|
|
|
Steps:
|
|
1. cd /workspace/project
|
|
2. Find the spec file: ls spec/ and look for a file matching the concept title slug
|
|
3. Read the spec file completely
|
|
4. Review it against architectural best practices:
|
|
- Are requirements testable and unambiguous?
|
|
- Are there security implications not addressed?
|
|
- Are interfaces and data contracts clearly defined?
|
|
- Are edge cases and failure modes covered?
|
|
5. Write your review findings to /workspace/.agent-output/review.md with a PASS or
|
|
REWORK verdict and specific findings
|
|
6. Call task_complete with "PASS" or "REWORK: <one-line reason>"
|
|
escalation:
|
|
contract_ambiguous: review-spec-opus |