Add memory files for review-plan and review-spec skills
Skill documentation for the new plan/spec review skills. Each file covers purpose, usage, how it works, referenced best practice files, and gotchas. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -25,6 +25,8 @@
|
||||
- [/housekeeping](memory/skill-housekeeping.md) — Cross-project health check: git status, unreflected logs, skill validation, pipeline recommendations
|
||||
- [/decompose](memory/skill-decompose.md) — Break tasks into subtasks with dependency graph, write .agent-tasks.json for container agent orchestration
|
||||
- [/orchestrate](memory/skill-orchestrate.md) — Check task state, launch container agents in git worktrees. Use `/loop 2m /orchestrate` for auto-polling
|
||||
- [/review-plan](memory/skill-review-plan.md) — Review plan against best practices (API, security, specs, TDD) before implementation
|
||||
- [/review-spec](memory/skill-review-spec.md) — Review spec for structure, requirement quality, security coverage, and testability
|
||||
|
||||
## References
|
||||
|
||||
@@ -36,3 +38,4 @@
|
||||
- [Process Lessons](memory/process-lessons.md) — Working rules: git-status at session start, plan mode for architecture, hook exit codes, ssh-agent
|
||||
- [Gitea Gotchas](memory/gotchas-gitea.md) — Push permission denied when repo created by different API user than SSH alias
|
||||
- [Skills Gotchas](memory/gotchas-skills.md) — Broken symlinks under set -e, mid-session skill discovery limitation
|
||||
- [Statusline Gotchas](memory/gotchas-statusline.md) — set-topic.sh bootstrap race condition, md5sum -n flag consistency
|
||||
|
||||
29
memory/skill-review-plan.md
Normal file
29
memory/skill-review-plan.md
Normal file
@@ -0,0 +1,29 @@
|
||||
# Skill: review-plan
|
||||
|
||||
## Purpose
|
||||
Reviews a plan file (*-PLAN.md) against best practices before implementation begins. Catches security gaps, missing specs, untested assumptions, and API design issues early -- when they're cheap to fix.
|
||||
|
||||
## Usage
|
||||
```
|
||||
/review-plan M2-auth-PLAN.md
|
||||
/review-plan # prompts to select from *-PLAN.md files
|
||||
```
|
||||
|
||||
## How it works
|
||||
1. Loads 5 best practice files: api-design, llm-code-security, spec-driven-development, test-driven-development, security-architecture
|
||||
2. Reads the specified plan file
|
||||
3. Evaluates against a 6-area checklist: security by design, API design, LLM code security, spec-driven development, test-driven development, operational readiness
|
||||
4. Outputs a scorecard, critical gaps, recommendations, and acknowledgment of what's done well
|
||||
|
||||
## Best practice files referenced
|
||||
- `~/dev/claude/projects/best-practices/api-design.md`
|
||||
- `~/dev/claude/projects/best-practices/llm-code-security.md`
|
||||
- `~/dev/claude/projects/best-practices/spec-driven-development.md`
|
||||
- `~/dev/claude/projects/best-practices/test-driven-development.md`
|
||||
- `~/dev/claude/projects/best-practices/security-architecture.md`
|
||||
- Plus any tech-stack-specific files from the index
|
||||
|
||||
## Gotchas
|
||||
- Read-only skill (allowed-tools: Read, Glob, Grep, Bash cat/ls/find). Cannot edit files.
|
||||
- Relies on best-practices repo being cloned at `~/dev/claude/projects/best-practices/`
|
||||
- The `~/` path in the bang-command generates a validator warning but works in practice
|
||||
32
memory/skill-review-spec.md
Normal file
32
memory/skill-review-spec.md
Normal file
@@ -0,0 +1,32 @@
|
||||
# Skill: review-spec
|
||||
|
||||
## Purpose
|
||||
Reviews a spec file against best practices for structure quality, requirement testability, security coverage, and API design. Ensures specs are implementation-ready before agents start coding.
|
||||
|
||||
## Usage
|
||||
```
|
||||
/review-spec spec/authentication.md
|
||||
/review-spec # reads SPEC.md and prompts to select
|
||||
```
|
||||
|
||||
## How it works
|
||||
1. Loads 5 best practice files: spec-driven-development, test-driven-development, api-design, llm-code-security, security-architecture
|
||||
2. Reads the specified spec file and SPEC.md index
|
||||
3. Evaluates 4 dimensions: structure completeness, requirement quality, security coverage, testability
|
||||
4. Checks every numbered requirement for testability, unambiguity, and rationale
|
||||
5. Identifies missing requirements and scenarios
|
||||
6. Outputs a scored review (1-5 per area), critical issues, missing requirements/scenarios, and recommendations
|
||||
|
||||
## Best practice files referenced
|
||||
- `~/dev/claude/projects/best-practices/spec-driven-development.md`
|
||||
- `~/dev/claude/projects/best-practices/test-driven-development.md`
|
||||
- `~/dev/claude/projects/best-practices/api-design.md`
|
||||
- `~/dev/claude/projects/best-practices/llm-code-security.md`
|
||||
- `~/dev/claude/projects/best-practices/security-architecture.md`
|
||||
- Plus any tech-stack-specific files from the index
|
||||
|
||||
## Gotchas
|
||||
- Read-only skill (allowed-tools: Read, Glob, Grep, Bash cat/ls/find). Cannot edit files.
|
||||
- Relies on best-practices repo being cloned at `~/dev/claude/projects/best-practices/`
|
||||
- The `~/` path in the bang-command generates a validator warning but works in practice
|
||||
- Counts requirements and verifies summary counts -- catches stale counts after edits
|
||||
Reference in New Issue
Block a user